Use config option to determine whether to add coeffs_reconstruct to the stream#448
Draft
cbegeman wants to merge 2 commits intoE3SM-Project:mainfrom
Draft
Use config option to determine whether to add coeffs_reconstruct to the stream#448cbegeman wants to merge 2 commits intoE3SM-Project:mainfrom
cbegeman wants to merge 2 commits intoE3SM-Project:mainfrom
Conversation
Collaborator
Author
|
@xylar Let me know what you think. Pro of using this approach: no need to run a separate forward step besides those being run. ( Con of using this approach: if there are multiple forward steps for a single test case (corresponding to the config file for which |
3da3ae4 to
b548c38
Compare
Collaborator
Author
|
The plan will be to
|
Collaborator
Author
|
This PR addresses #445 |
b548c38 to
36bad9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use config option to determine whether to add coeffs_reconstruct to the stream for forward steps.
Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes